1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 00:38:00 +01:00
Commit Graph

17 Commits

Author SHA1 Message Date
Doug Kearns
afc14aff65 Remove :edit, :tabedit and :winedit aliases. 2009-11-14 04:20:26 +11:00
Kris Maglione
6a25312c7d Recfactoring:
* Standard module format. All modules are explicitly declared
   as modules, they're created via a constructor and
   instantiated automatically. They're dependency aware. They
   stringify properly.

 * Classes are declared the same way (rather like Structs
   already were). They also stringify properly. Plus, each
   instance has a rather nifty closure member that closes all
   of its methods around 'this', so you can pass them to map,
   forEach, setTimeout, etc. Modules are themselves classes,
   with a special metaclass, as it were.

 * Doug Crockford is dead, metaphorically speaking.
   Closure-based classes just don't fit into any of the common
   JavaScript frameworks, and they're inefficient and
   confusing. Now, all class and module members are accessed
   explicitly via 'this', which makes it very clear that
   they're class members and not (e.g.) local variables,
   without anything nasty like Hungarian notation.

 * Strictly one module per file. Classes that belong to a
   module live in the same file.

 * For the moment, there are quite a few utility functions
   sitting in base.c, because my class implementation used
   them, and I haven't had the time or inclination to sort them
   out. I plan to reconcile them with the current mess that is
   the util namespace.

 * Changed bracing style.
2009-11-08 20:54:31 -05:00
Kris Maglione
7a9889b18c Add IO#File.
New review:
owner: dougkearns
I like this for the most part, except that it has to go to lengths
to wrap the original nsIFile correctly, an that it can't be passed
directly to other XPCOM components. It makes most operations on
files a lot cleaner, though.
2009-10-31 17:40:16 -04:00
Kris Maglione
d880d4afcb Cleanup liberator.open a bit; could probably use a bit more. 2009-10-31 17:28:35 -04:00
Kris Maglione
9bb01ce7ef Change Storage#newObject signature. 2009-10-29 20:30:24 -04:00
Doug Kearns
2d8c65a7b8 Normalise the browser.js header. 2009-10-03 17:00:18 +10:00
Doug Kearns
2b7e4dcb67 Remove redundant semicolons. 2009-09-04 21:58:43 +10:00
Doug Kearns
339592c4a2 Fix 'encoding' names.
Options require literal names.
2009-09-04 20:21:51 +10:00
Kris Maglione
b8d972ca94 Make some attempt to respect "Clear Private Data" 2009-09-03 17:29:26 -04:00
Kris Maglione
9d77c018ca Fix something to do with <a>. 2009-08-19 14:03:14 -04:00
Doug Kearns
b6d3f7ef99 Remove some trailing commas. 2009-08-10 02:21:47 +10:00
Doug Kearns
77458e5b8a Whitespace and semicolon fixes. 2009-08-10 02:15:23 +10:00
Doug Kearns
c47a0ec1cc Normalise the use of "regexp(s)" vs "regex(es)".
"regex" won the Google battle.
2009-07-11 15:50:48 +10:00
Doug Kearns
1f7b6f4b05 Make :open <noarg> behaviour match that of :tabopen/:winopen. 2009-07-11 00:43:27 +10:00
Doug Kearns
cdb7cfeb35 Remove 'online' definition from Browser.
This is currently config specific.
2009-07-07 22:16:00 +10:00
Doug Kearns
3a904b16d9 Remove duplication of command/option defintions in Browser. 2009-07-06 04:06:04 +10:00
Doug Kearns
ed62a23c83 Extract common browser related behaviour into a new browser module. 2009-07-02 17:17:13 +10:00