From fe86a19e35d6bee4c72ad23949efdaebbc912eb0 Mon Sep 17 00:00:00 2001 From: cheater Date: Wed, 8 Feb 2012 07:39:02 +0100 Subject: [PATCH] Added a FIXME for the 'except Exception'. --- plugin/pythonhelper.vim | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/plugin/pythonhelper.vim b/plugin/pythonhelper.vim index 436f68c..6c2bc67 100644 --- a/plugin/pythonhelper.vim +++ b/plugin/pythonhelper.vim @@ -628,6 +628,13 @@ def findTag(bufferNumber, changedTick): # handle possible exceptions {{{ except Exception: + # FIXME: wrap try/except blocks around single sources of exceptions + # ONLY. Break this try/except block into as many small ones as you + # need, and only catch classes of exceptions that you have encountered. + # Catching "Exception" is very, very bad style! + # To the author: why is this clause here? There's no git log for why you + # have added it. Can you please put in a comment of a specific situation + # where you have encountered exceptions? # bury into the traceback {{{ ec, ei, tb = sys.exc_info() while (tb != None):