Code review refactoring

rtv/clipboard.py

@@ -1,42 +1,52 @@
 # -*- coding: utf-8 -*-
-import os
-import platform
+from __future__ import unicode_literals
+
+import sys
 import subprocess
 
 from .exceptions import ProgramError
 
+
 def _subprocess_copy(text, args_list):
     p = subprocess.Popen(args_list, stdin=subprocess.PIPE, close_fds=True)
     p.communicate(input=text.encode('utf-8'))
 
+
 def copy(text):
     """
     Copy text to OS clipboard.
     """
 
-    if os.name == 'mac' or platform.system() == 'Darwin':
-        return copy_osx(text)
-    elif os.name == 'posix' or platform.system() == 'Linux':
-        return copy_linux(text)
+    if sys.platform == 'darwin':
+        copy_osx(text)
     else:
-        raise NotImplementedError
+        # For Linux, BSD, cygwin, etc.
+        copy_linux(text)
+
 
 def copy_osx(text):
     _subprocess_copy(text, ['pbcopy', 'w'])
 
+
 def copy_linux(text):
+
     def get_command_name():
         # Checks for the installation of xsel or xclip
         for cmd in ['xsel', 'xclip']:
             cmd_exists = subprocess.call(
                 ['which', cmd],
-                stdout=subprocess.PIPE, stderr=subprocess.PIPE) is 0
+                stdout=subprocess.PIPE, stderr=subprocess.PIPE) == 0
             if cmd_exists:
                 return cmd
         return None
-    cmd_args = {'xsel' : ['xsel', '-b', '-i'],
-                'xclip' : ['xclip', '-selection', 'c']}
+
+    cmd_args = {
+        'xsel': ['xsel', '-b', '-i'],
+        'xclip': ['xclip', '-selection', 'c']}
     cmd_name = get_command_name()
+
     if cmd_name is None:
-        raise ProgramError("External copy application not installed")
+        raise ProgramError("External copy application not found,\n"
+                           "try installing either `xsel` or `xclip`")
+
     _subprocess_copy(text, cmd_args.get(cmd_name))