Merge pull request #230 from michael-lazar/slash_subreddit

Check for empty subreddit name.

rtv/content.py

@@ -6,6 +6,7 @@ from datetime import datetime
 
 import six
 import praw
+from praw.errors import InvalidSubreddit
 from kitchen.text.display import wrap
 
 from . import exceptions
@@ -398,6 +399,11 @@ class SubredditContent(Content):
                 submissions = reddit.search(query, subreddit=name, sort=order)
 
         else:
+            if name == '':
+                # Praw does not correctly handle empty strings
+                # https://github.com/praw-dev/praw/issues/615
+                raise InvalidSubreddit()
+
             if name == 'front':
                 dispatch = {
                     None: reddit.get_front_page,

tests/test_content.py

@@ -259,6 +259,14 @@ def test_content_subreddit_from_name(reddit, terminal):
         SubredditContent.from_name(reddit, name, terminal.loader)
     assert isinstance(terminal.loader.exception, exceptions.SubredditError)
 
+    # A couple of edge cases
+    names = ['', '/', '//', '/////////////////']
+    for name in names:
+        with terminal.loader():
+            SubredditContent.from_name(reddit, name, terminal.loader)
+        assert isinstance(terminal.loader.exception,
+                          praw.errors.InvalidSubreddit)
+
     # Front page alias
     name = '/r/front/rising'
     content = SubredditContent.from_name(reddit, name, terminal.loader)
@@ -344,4 +352,4 @@ def test_content_subscription_empty(terminal):
 
     with terminal.loader():
         SubscriptionContent(subscriptions, terminal.loader)
-    assert isinstance(terminal.loader.exception, exceptions.SubscriptionError)
+    assert isinstance(terminal.loader.exception, exceptions.SubscriptionError)