From feb9842784a6356f9d0b1355fbf69478eedf1bfd Mon Sep 17 00:00:00 2001 From: Lawrence Vanderpool Date: Mon, 2 Mar 2015 09:22:53 -0500 Subject: [PATCH 1/2] changed password to a getpass prompt for all sorts of security reasons --- rtv/main.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/rtv/main.py b/rtv/main.py index f69284a..7acf619 100644 --- a/rtv/main.py +++ b/rtv/main.py @@ -6,6 +6,8 @@ from rtv.errors import SubmissionURLError, SubredditNameError from rtv.utils import curses_session from rtv.subreddit import SubredditPage from rtv.submission import SubmissionPage +import ConfigParser +from getpass import getpass description = """ Reddit Terminal Viewer is a lightweight browser for www.reddit.com built into a @@ -30,7 +32,6 @@ def main(): group = parser.add_argument_group('authentication (optional)') group.add_argument('-u', dest='username', help='reddit username') - group.add_argument('-p', dest='password', help='reddit password') args = parser.parse_args() @@ -38,8 +39,9 @@ def main(): reddit = praw.Reddit(user_agent='reddit terminal viewer v0.0') reddit.config.decode_html_entities = True - if args.username and args.password: - reddit.login(args.username, args.password) + if args.username: + password = getpass() + reddit.login(args.username, password) with curses_session() as stdscr: From 7c7606d288b0ec306577cb1c79b3ea9cb90e4caf Mon Sep 17 00:00:00 2001 From: Lawrence Vanderpool Date: Mon, 2 Mar 2015 14:05:05 -0500 Subject: [PATCH 2/2] reimplemented the -p option and removed an unnecessary import --- rtv/main.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rtv/main.py b/rtv/main.py index 7acf619..a37b403 100644 --- a/rtv/main.py +++ b/rtv/main.py @@ -6,7 +6,6 @@ from rtv.errors import SubmissionURLError, SubredditNameError from rtv.utils import curses_session from rtv.subreddit import SubredditPage from rtv.submission import SubmissionPage -import ConfigParser from getpass import getpass description = """ @@ -32,6 +31,7 @@ def main(): group = parser.add_argument_group('authentication (optional)') group.add_argument('-u', dest='username', help='reddit username') + group.add_argument('-p', dest='password', help='reddit password') args = parser.parse_args() @@ -40,8 +40,11 @@ def main(): reddit.config.decode_html_entities = True if args.username: - password = getpass() - reddit.login(args.username, password) + if args.password: + reddit.login(args.username, args.password) + else: + password = getpass() + reddit.login(args.username, password) with curses_session() as stdscr: