From d32482afb9f82659d8117261790014fe1e8eada8 Mon Sep 17 00:00:00 2001 From: Tom Van Braeckel Date: Wed, 5 Nov 2014 07:32:28 +0100 Subject: [PATCH] Automatic reconnect: honour the automatic reconnect configuration, even if the GUI interface is open When a user actives "automatic reconnnect" and then tries this out, he will be staring at the GUI interface, waiting for a reconnect. But wicd-daemon refuses to reconnect when the GUI interface is open, and fails to reports this to the GUI user. Hence users assume that this feature does not work properly (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567). This commit fixes that by doing a reconnect, no matter whether the GUI is open or not, thus taking the path of "least surprise". The original rationale for not reconnecting when the GUI is open was never stated in the comments, nor in the commit message. --- wicd/wicd-daemon.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/wicd/wicd-daemon.py b/wicd/wicd-daemon.py index 05680f2..481e9c6 100644 --- a/wicd/wicd-daemon.py +++ b/wicd/wicd-daemon.py @@ -367,11 +367,6 @@ class WicdDaemon(dbus.service.Object, object): if self.debug_mode: print 'Already connecting, doing nothing.' return - # We don't want to rescan/connect if the gui is open. - if self.gui_open: - if self.debug_mode: - print "Skipping autoconnect because GUI is open." - return if self.wired_bus.CheckPluggedIn(): if self.debug_mode: print "Starting wired autoconnect..."