gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-02-05 15:55:56 +01:00
Code Issues Projects Releases Wiki Activity

Fix uninitialized vars

Browse Source 
Initialized variables that are conditionally set. In particular, this
construct is dangerous:
  void *p;
  if (something) p = couldReturnNull();
  if (!p) p = fallbackFunction();
This commit is contained in:
Brad Jorsch
2010-04-08 14:43:52 -04:00
committed by Carlos R. Mafra
parent bbf3635590
commit 12de2f319e
6 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
WPrefs.app/Appearance.c
View File

@@ -544,7 +544,7 @@ static Pixmap renderTexture(WMScreen * scr, WMPropList * texture, int width, int
int style;
RColor rcolor2;
int i;
RImage *grad, *timage;
RImage *grad, *timage = NULL;
char *path;
switch (toupper(type[1])) {

5
WPrefs.app/Paths.c
View File

@@ -22,6 +22,7 @@
#include "WPrefs.h"
#include <unistd.h>
#include <assert.h>
typedef struct _Panel {
WMBox *box;
@@ -131,6 +132,8 @@ static void browseForFile(WMWidget * w, void *data)
_Panel *panel = (_Panel *) data;
WMFilePanel *filePanel;
assert(w == panel->icoaB || w == panel->pixaB);
filePanel = WMGetOpenPanel(WMWidgetScreen(w));
WMSetFilePanelCanChooseFiles(filePanel, False);
@@ -147,7 +150,7 @@ static void browseForFile(WMWidget * w, void *data)
len--;
}
if (len > 0) {
WMList *lPtr;
WMList *lPtr = NULL;
int i;
if (w == panel->icoaB)