From 15db368291419e523d6787d5c968e312b1211b55 Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Sat, 25 Apr 2015 12:44:22 +0200 Subject: [PATCH] WINGs: fix memory leak in WMSubtractPLDictionaries (Coverity #50128) As pointed by Coverity, a temporary proplist is created with the list of keys to be removed from the source proplist, but this temporary proplist was not released at the end, leaking memory. Signed-off-by: Christophe CURIS --- WINGs/proplist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/WINGs/proplist.c b/WINGs/proplist.c index 28a3ae26..5f68eace 100644 --- a/WINGs/proplist.c +++ b/WINGs/proplist.c @@ -1213,6 +1213,7 @@ WMPropList *WMSubtractPLDictionaries(WMPropList * dest, WMPropList * source, Boo for (i = 0; i < WMGetArrayItemCount(keys->d.array); i++) { WMRemoveFromPLDictionary(dest, WMGetFromArray(keys->d.array, i)); } + WMReleasePropList(keys); return dest; }