gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-23 06:38:05 +01:00
Code Issues Projects Releases Wiki Activity

wmaker: do not store return value that we don't use (Coverity #50252)

Browse Source 
As pointed by Coverity, we store a value into the variable 'entry' but we
never use it later, although we re-use the variable.

For the maintainability of the code, it is not really good as it could
mislead into thinking the value could be used, so this patch removes the
assignation.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-11-29 16:35:24 +01:00
committed by Carlos R. Mafra
parent 8b78681a7f
commit 1bd9621709
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/dock.c
View File

@@ -1220,9 +1220,9 @@ static WMenu *dockMenuCreate(WScreen *scr, int type)
scr->dock_pos_menu = makeDockPositionMenu(scr);
wMenuEntrySetCascade(menu, entry, scr->dock_pos_menu);
if (!wPreferences.flags.nodrawer) {
entry = wMenuAddCallback(menu, _("Add a drawer"), addADrawerCallback, NULL);
}
if (!wPreferences.flags.nodrawer)
wMenuAddCallback(menu, _("Add a drawer"), addADrawerCallback, NULL);
} else {
if (type == WM_CLIP)
entry = wMenuAddCallback(menu, _("Clip Options"), NULL, NULL);