gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-01-08 23:04:15 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: fix possible NULL pointer dereference in WMFreeColorPanel (Coverity #50189)

Browse Source 
As pointed by Coverity, the code was checking for NULL pointer to avoid
misbehaviour, but it actually dereferenced the pointer beforehand so the
crash would still happen.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-18 21:31:48 +02:00
committed by Carlos R. Mafra
parent 354ec080ad
commit 21c891e669
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
WINGs/wcolorpanel.c
View File

@@ -1097,15 +1097,16 @@ WMColorPanel *WMGetColorPanel(WMScreen * scrPtr)
void WMFreeColorPanel(WMColorPanel * panel) void WMFreeColorPanel(WMColorPanel * panel)
{ {
W_Screen *scr = WMWidgetScreen(panel->win); W_Screen *scr;
if (panel == scr->sharedColorPanel) {
scr->sharedColorPanel = NULL;
}
if (!panel) if (!panel)
return; return;
scr = WMWidgetScreen(panel->win);
if (panel == scr->sharedColorPanel) {
scr->sharedColorPanel = NULL;
}
WMRemoveNotificationObserver(panel); WMRemoveNotificationObserver(panel);
WMUnmapWidget(panel->win); WMUnmapWidget(panel->win);