From 26d46f6e16ee2abc676bec32878b97f647bc9b8e Mon Sep 17 00:00:00 2001 From: David Maciejak Date: Thu, 2 Mar 2023 19:26:01 +0800 Subject: [PATCH] Coverity: fix WPrefs menu negative array index read --- WPrefs.app/Menu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/WPrefs.app/Menu.c b/WPrefs.app/Menu.c index 87c7a34d..20b992ce 100644 --- a/WPrefs.app/Menu.c +++ b/WPrefs.app/Menu.c @@ -291,6 +291,8 @@ static void changedItemPad(WMWidget * w, void *data) _Panel *panel = (_Panel *) data; int padn = WMGetPopUpButtonSelectedItem(w); + if (padn < 0) + return; WMUnmapWidget(panel->itemPad[panel->currentPad]); WMMapWidget(panel->itemPad[padn]);