From 27a2259934aabb98b90adc633ab8366205284a5e Mon Sep 17 00:00:00 2001
From: Christophe CURIS <christophe.curis@free.fr>
Date: Sat, 31 May 2014 19:58:44 +0200
Subject: [PATCH] WPrefs: fix memory leak when editing the label of a menu
 (Coverity #50130)

As pointed by Coverity, the function 'WMGetTextFieldText' already allocates
memory for its return string, so it is not necessary to wstrdup it.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
---
 WPrefs.app/editmenu.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/WPrefs.app/editmenu.c b/WPrefs.app/editmenu.c
index c3cf296a..7a9b29b9 100644
--- a/WPrefs.app/editmenu.c
+++ b/WPrefs.app/editmenu.c
@@ -809,13 +809,9 @@ static void handleEvents(XEvent * event, void *data)
 
 static void stopEditItem(WEditMenu * menu, Bool apply)
 {
-	char *text;
-
 	if (apply) {
-		text = WMGetTextFieldText(menu->tfield);
-
 		wfree(menu->selectedItem->label);
-		menu->selectedItem->label = wstrdup(text);
+		menu->selectedItem->label = WMGetTextFieldText(menu->tfield);
 
 		updateMenuContents(menu);