From 2b65b0416ed22c50a92298c749e867abec45d8ac Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Sat, 15 Nov 2014 19:40:57 +0100 Subject: [PATCH] wmaker: fix size of element given to the 'qsort' function (Coverity #50210) As pointed by Coverity, the sizeof used was not done on the right type. This worked because the element was a pointer all pointers types have the same size in most platforms. For code maintainability, the code will now take the size from the first element of the array to be sorted, so that if the structure gets changed someday the expression will stay valid. Signed-off-by: Christophe CURIS Signed-off-by: Carlos R. Mafra --- src/moveres.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/moveres.c b/src/moveres.c index e00b3ed8..8640511c 100644 --- a/src/moveres.c +++ b/src/moveres.c @@ -776,10 +776,10 @@ static void updateMoveData(WWindow * wwin, MoveData * data) /* order from closest to the border of the screen to farthest */ - qsort(data->topList, data->count, sizeof(WWindow **), compareWTop); - qsort(data->leftList, data->count, sizeof(WWindow **), compareWLeft); - qsort(data->rightList, data->count, sizeof(WWindow **), compareWRight); - qsort(data->bottomList, data->count, sizeof(WWindow **), compareWBottom); + qsort(data->topList, data->count, sizeof(data->topList[0]), compareWTop); + qsort(data->leftList, data->count, sizeof(data->leftList[0]), compareWLeft); + qsort(data->rightList, data->count, sizeof(data->rightList[0]), compareWRight); + qsort(data->bottomList, data->count, sizeof(data->bottomList[0]), compareWBottom); /* figure the position of the window relative to the others */