gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-19 20:38:08 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: fix probable crash in drag'n'drop (Coverity #50264)

Browse Source 
As reported by Coverity, the structure containing the callback functions
to handle the drag-and-drop actions could be freed but later re-used.
The correct behaviour is to keep the allocated memory for the structure.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-18 21:31:52 +02:00
committed by Carlos R. Mafra
parent 7a39f32816
commit 3a191af838
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
WINGs/dragdestination.c
View File

@@ -974,8 +974,6 @@ void WMSetViewDragDestinationProcs(WMView * view, WMDragDestinationProcs * procs
{ {
if (view->dragDestinationProcs == NULL) { if (view->dragDestinationProcs == NULL) {
view->dragDestinationProcs = wmalloc(sizeof(WMDragDestinationProcs)); view->dragDestinationProcs = wmalloc(sizeof(WMDragDestinationProcs));
} else {
free(view->dragDestinationProcs);
} }
*view->dragDestinationProcs = *procs; *view->dragDestinationProcs = *procs;