From 3d9c059591486dd65d4ce2a3be81c1e68a9a0c04 Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Sat, 15 Nov 2014 19:40:38 +0100 Subject: [PATCH] wmaker: removed unnecessary check when painting application icon (Coverity #50052) As pointed by Coverity, there was a check for null pointer on scr->dock_dots, but this check was not made in the 2nd use of it, done if the HIDDENDOT feature was enabled. Investigation show that it is not possible that this pointer could be created NULL, so let's remove the unneeded check. Signed-off-by: Christophe CURIS Signed-off-by: Carlos R. Mafra --- src/appicon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/appicon.c b/src/appicon.c index 524fded7..1d28a245 100644 --- a/src/appicon.c +++ b/src/appicon.c @@ -411,7 +411,7 @@ void wAppIconPaint(WAppIcon *aicon) if (aicon->docked && scr->dock && scr->dock == aicon->dock && aicon->yindex == 0) updateDockNumbers(scr); # endif - if (scr->dock_dots && aicon->docked && !aicon->running && aicon->command != NULL) { + if (aicon->docked && !aicon->running && aicon->command != NULL) { XSetClipMask(dpy, scr->copy_gc, scr->dock_dots->mask); XSetClipOrigin(dpy, scr->copy_gc, 0, 0); XCopyArea(dpy, scr->dock_dots->image, aicon->icon->core->window,