gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-19 04:20:27 +01:00
Code Issues Projects Releases Wiki Activity

WPrefs: Fix memory leak in the Menu tab

Browse Source 
As reported by Coverity (CID #331559), the call to 'wfindfile' replaces
the value for variable 'path' but we did not free its previous content.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2021-05-14 20:17:04 +02:00
committed by Carlos R. Mafra
parent e828e1c074
commit 4559cbbccc
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
WPrefs.app/Menu.c
View File

@@ -1502,8 +1502,12 @@ static void showData(_Panel * panel)
path = wexpandpath(WMGetFromPLString(pmenu)); path = wexpandpath(WMGetFromPLString(pmenu));
if (access(path, F_OK) < 0) if (access(path, F_OK) < 0) {
char *old_path = path;
path = wfindfile(DEF_CONFIG_PATHS, path); path = wfindfile(DEF_CONFIG_PATHS, path);
wfree(old_path);
}
/* TODO: if needed, concatenate locale suffix to path. /* TODO: if needed, concatenate locale suffix to path.
See getLocalizedMenuFile() in src/rootmenu.c. */ See getLocalizedMenuFile() in src/rootmenu.c. */