From 572af55c9f94fe09aa83b6a22594ce8012db3f63 Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Sat, 15 Nov 2014 19:40:39 +0100 Subject: [PATCH] wmaker: removed unnecessary assignation (Coverity #50257) As pointed by Coverity, the return value is saved into a variable, but this value is never used. As the variable is re-used afterwards, this assignation could mislead on what is done, so for code maintainability the value is just ignored. Signed-off-by: Christophe CURIS Signed-off-by: Carlos R. Mafra --- src/client.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/client.c b/src/client.c index fe9a64ae..99ed445c 100644 --- a/src/client.c +++ b/src/client.c @@ -574,6 +574,7 @@ void wClientCheckProperty(WWindow * wwin, XPropertyEvent * event) if (foo->fake_group && foo->fake_group == fPtr) { WSETUFLAG(foo, shared_appicon, 0); foo->fake_group = NULL; + if (foo->group_id != None) foo->main_window = foo->group_id; else if (foo->client_leader != None) @@ -582,9 +583,9 @@ void wClientCheckProperty(WWindow * wwin, XPropertyEvent * event) foo->main_window = foo->client_win; else foo->main_window = None; - if (foo->main_window) { - wapp = wApplicationCreate(foo); - } + + if (foo->main_window) + wApplicationCreate(foo); } foo = foo->prev; }