gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-02-03 14:55:46 +01:00
Code Issues Projects Releases Wiki Activity

Fix some warnings

Browse Source 
Non-obvious fixes:

WINGs/wfilepanel.c: Cast to void to avoid an unused calculated value
warning.

WINGs/wtabview.c: Test tab<0 to avoid a warning from the next condition
about signed overflow in an inlined invocation of the function.

Signed-off-by: Brad Jorsch <anomie@users.sourceforge.net>
This commit is contained in:
Brad Jorsch
2010-10-08 15:08:30 -04:00
committed by Carlos R. Mafra
parent 51134d2438
commit 5eebb8bc3c
7 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
WINGs/dragdestination.c
View File

@@ -311,13 +311,13 @@ void W_DragDestinationStoreEnterMsgInfo(WMDraggingInfo * info, WMView * toplevel
XDND_AWARE_VIEW(info) = toplevel;
updateSourceWindow(info, event);
/*
#if 0
if (event->data.l[1] & 1)
/* XdndTypeList property is available */
/* XDND_SOURCE_TYPES(info) = getTypesFromTypeList(scr, XDND_SOURCE_WIN(info));
XDND_SOURCE_TYPES(info) = getTypesFromTypeList(scr, XDND_SOURCE_WIN(info));
else
XDND_SOURCE_TYPES(info) = getTypesFromThreeTypes(scr, event);
*/
#endif
XDND_SOURCE_TYPES(info) = getTypesFromThreeTypes(scr, event);
/* to use if the 3 types are not enough */

2
WINGs/wfilepanel.c
View File

@@ -662,7 +662,7 @@ static void normalizePath(char *s)
int i, j, found;
found = 0;
for (i = 0; s[i]; !found && i++) {
for (i = 0; s[i]; (void)(!found && i++)) {
found = 0;
if (s[i] == '/' && s[i+1] == '/') {
int nslash = 1;

2
WINGs/wtabview.c
View File

@@ -93,7 +93,7 @@ static int positionOfTab(WMTabView * tabView, int tab)
int i;
int offs;
if (tab < tabView->firstVisible)
if (tab < 0 || tab < tabView->firstVisible)
return -1;
if (tab > tabView->firstVisible + tabView->visibleTabs)