gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-19 04:20:27 +01:00
Code Issues Projects Releases Wiki Activity

Fix some warnings

Browse Source 
Non-obvious fixes:

WINGs/wfilepanel.c: Cast to void to avoid an unused calculated value
warning.

WINGs/wtabview.c: Test tab<0 to avoid a warning from the next condition
about signed overflow in an inlined invocation of the function.

Signed-off-by: Brad Jorsch <anomie@users.sourceforge.net>
This commit is contained in:
Brad Jorsch
2010-10-08 15:08:30 -04:00
committed by Carlos R. Mafra
parent 51134d2438
commit 5eebb8bc3c
7 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
WINGs/dragdestination.c
View File

@@ -311,13 +311,13 @@ void W_DragDestinationStoreEnterMsgInfo(WMDraggingInfo * info, WMView * toplevel
XDND_AWARE_VIEW(info) = toplevel;
updateSourceWindow(info, event);
/*
#if 0
if (event->data.l[1] & 1)
/* XdndTypeList property is available */
/* XDND_SOURCE_TYPES(info) = getTypesFromTypeList(scr, XDND_SOURCE_WIN(info));
XDND_SOURCE_TYPES(info) = getTypesFromTypeList(scr, XDND_SOURCE_WIN(info));
else
XDND_SOURCE_TYPES(info) = getTypesFromThreeTypes(scr, event);
*/
#endif
XDND_SOURCE_TYPES(info) = getTypesFromThreeTypes(scr, event);
/* to use if the 3 types are not enough */

2
WINGs/wfilepanel.c
View File

@@ -662,7 +662,7 @@ static void normalizePath(char *s)
int i, j, found;
found = 0;
for (i = 0; s[i]; !found && i++) {
for (i = 0; s[i]; (void)(!found && i++)) {
found = 0;
if (s[i] == '/' && s[i+1] == '/') {
int nslash = 1;

2
WINGs/wtabview.c
View File

@@ -93,7 +93,7 @@ static int positionOfTab(WMTabView * tabView, int tab)
int i;
int offs;
if (tab < tabView->firstVisible)
if (tab < 0 || tab < tabView->firstVisible)
return -1;
if (tab > tabView->firstVisible + tabView->visibleTabs)

2
src/actions.c
View File

@@ -1225,10 +1225,8 @@ void wHideAll(WScreen *scr)
{
WWindow *wwin;
WWindow **windows;
Window FocusedWin;
WMenu *menu;
unsigned int wcount = 0;
int FocusState;
int i;
if (!scr)

3
src/event.c
View File

@@ -914,7 +914,6 @@ static void handlePropertyNotify(XEvent * event)
Window jr;
int ji;
unsigned int ju;
WScreen *scr;
wwin = wWindowFor(event->xproperty.window);
if (wwin) {
@@ -927,8 +926,6 @@ static void handlePropertyNotify(XEvent * event)
if (wapp) {
wClientCheckProperty(wapp->main_window_desc, &event->xproperty);
}
scr = wScreenForWindow(event->xproperty.window);
}
static void handleClientMessage(XEvent * event)

5
src/startup.c
View File

@@ -508,7 +508,10 @@ static char *atomNames[] = {
void StartUp(Bool defaultScreenOnly)
{
struct sigaction sig_action;
int j, max, dummy;
int j, max;
#ifdef HAVE_XRANDR
int dummy;
#endif
Atom atom[sizeof(atomNames) / sizeof(char *)];
/*

2
wrlib/scale.c
View File

@@ -55,8 +55,6 @@ RImage *RScaleImage(RImage * image, unsigned new_width, unsigned new_height)
unsigned char *d;
RImage *img;
assert(new_width >= 0 && new_height >= 0);
if (new_width == image->width && new_height == image->height)
return RCloneImage(image);