From 752a9494923fc81ebf92fa872dcef964d9f842fe Mon Sep 17 00:00:00 2001 From: David Maciejak Date: Tue, 17 Mar 2026 20:12:38 -0400 Subject: [PATCH] wmaker: fix window position issues with dockapps The patch with commit 839061a25a87877d741abf68699095b40c5f86a6 introduces an issue with dockapps that are creating their main windows with size 1x1. That new patch is moving the existing code further below in the wManageWindow function to be able to check if the window flag is_dockapp is set. Issue was seen with wmsystemtray and wmmemload. --- src/window.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/window.c b/src/window.c index 032ead46..78b2271c 100644 --- a/src/window.c +++ b/src/window.c @@ -688,15 +688,6 @@ WWindow *wManageWindow(WScreen *scr, Window window) return NULL; } - /* Some applications create placeholder windows with 1x1 size - * (e.g. VirtualBox internal windows). Don't manage those initial - * 1x1 windows — wait for a proper ConfigureNotify/MapRequest with - * a real size. */ - if (wattribs.width <= 1 && wattribs.height <= 1) { - XUngrabServer(dpy); - return NULL; - } - wm_state = PropGetWindowState(window); /* if it's startup and the window is unmapped, don't manage it */ @@ -810,6 +801,15 @@ WWindow *wManageWindow(WScreen *scr, Window window) /* get geometry stuff */ wClientGetNormalHints(wwin, &wattribs, True, &x, &y, &width, &height); + /* Some applications create placeholder windows with 1x1 size + * (e.g. VirtualBox internal windows). Don't manage those initial + * 1x1 windows. */ + if (width <= 1 && height <= 1 && !wwin->flags.is_dockapp) { + wWindowDestroy(wwin); + XUngrabServer(dpy); + return NULL; + } + /* get colormap windows */ GetColormapWindows(wwin);