From 7f840db1aa0882e81225b66ad18820a048f3d069 Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Tue, 20 May 2014 21:46:29 +0200 Subject: [PATCH] WMaker: remove unnecessary check in Balloon show function (Coverity #50065) As pointed by Coverity, there is a check to make sure a pointer is not NULL but it is still dereferenced later in the function. As the code is done so that this pointer cannot be NULL then it is not necessary to check that. Signed-off-by: Christophe CURIS --- src/balloon.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/balloon.c b/src/balloon.c index 6c056e44..b9c77bb2 100644 --- a/src/balloon.c +++ b/src/balloon.c @@ -382,10 +382,8 @@ static void showBalloon(WScreen * scr) Window foow; unsigned foo, w; - if (scr->balloon) { - scr->balloon->timer = NULL; - scr->balloon->ignoreTimer = 1; - } + scr->balloon->timer = NULL; + scr->balloon->ignoreTimer = 1; if (!XGetGeometry(dpy, scr->balloon->objectWindow, &foow, &x, &y, &w, &foo, &foo, &foo)) { scr->balloon->prevType = 0;