1
0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-19 20:38:08 +01:00

Revert "Inotify: Reload keyboard shortcut definitions when configuration changes"

This reverts commit cbe2f4e61a.

The reason for the revert is the regression reported here:
http://marc.info/?l=openbsd-ports&m=133151145814675&w=2

  I've been able to reliably reproduce the double-spawning of
  xterms I've been seeing. The bad news is that it still happens
  even with a fresh configuration directory.

  To reproduce:
  0) Create a keyboard shortcut if one does not already exist (I'm
  using <ctrl>+u set to spawn an xterm)
  1) Open WindowMaker's preferences.
  2) Click on "Applications Menu Definition" (it's the icon
  immediately to the left of the keyboard icon)
  3) Click save, and then close.
  4) Keyboard shortcuts will spawn two applications.

  I use keyboard shortcuts to spawn xterms, browsers, and filemanagers.
  All of them spawn twice after performing the above.  To fix it,
  <F12> or <right-click> -> Exit -> Restart.

  If I repeat steps 1-3, three windows will spawn.  Repeat again and
  four windows will spawn etc.  (I stopped after getting five to
  spawn at once).
This commit is contained in:
Carlos R. Mafra
2012-04-30 14:36:43 -03:00
parent 4e2ee27bfa
commit 8311058a16
3 changed files with 6 additions and 13 deletions

View File

@@ -61,7 +61,6 @@
#include "dock.h"
#include "workspace.h"
#include "properties.h"
#include "rootmenu.h"
#define MAX_SHORTCUT_LENGTH 32
@@ -1013,9 +1012,6 @@ void wDefaultsCheckDomains(void* arg)
}
WDRootMenu->dictionary = dict;
wDefaultsMergeGlobalMenus(WDRootMenu);
scr = wScreenWithNumber(0);
configureMenu(scr, dict, True);
rebind_key_grabs(scr);
}
} else {
wwarning(_("could not load domain %s from user defaults database"), "WMRootMenu");