1
0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-20 21:08:08 +01:00

Address unprototyped call in dock.c

Create a header file dockedapp.h to address a long-standing warning
which pollutes the compilation output with --enable-silent-rules:

Making all in src
  CC     dock.o
dock.c: In function ‘wDockDetach’:
dock.c:2118:3: warning: call to function ‘DestroyDockAppSettingsPanel’ without a real prototype [-Wunprototyped-calls]
dock.c:65:13: note: ‘DestroyDockAppSettingsPanel’ was declared here
  CCLD   wmaker
This commit is contained in:
Carlos R. Mafra
2012-06-23 12:04:29 +01:00
parent 0e671d3683
commit b6ced4fa5d
3 changed files with 68 additions and 43 deletions

View File

@@ -43,6 +43,7 @@
#include "actions.h" #include "actions.h"
#include "stacking.h" #include "stacking.h"
#include "dock.h" #include "dock.h"
#include "dockedapp.h"
#include "dialog.h" #include "dialog.h"
#include "funcs.h" #include "funcs.h"
#include "properties.h" #include "properties.h"
@@ -60,10 +61,6 @@
#define CLIP_FORWARD 2 #define CLIP_FORWARD 2
/**** Global variables ****/ /**** Global variables ****/
/* in dockedapp.c */
extern void DestroyDockAppSettingsPanel();
extern void ShowDockAppSettingsPanel(WAppIcon * aicon);
extern Cursor wCursor[WCUR_LAST]; extern Cursor wCursor[WCUR_LAST];
extern WPreferences wPreferences; extern WPreferences wPreferences;
extern XContext wWinContext; extern XContext wWinContext;

View File

@@ -31,6 +31,7 @@
#include "icon.h" #include "icon.h"
#include "appicon.h" #include "appicon.h"
#include "dock.h" #include "dock.h"
#include "dockedapp.h"
#include "dialog.h" #include "dialog.h"
#include "funcs.h" #include "funcs.h"
#include "defaults.h" #include "defaults.h"
@@ -40,45 +41,6 @@
/**** Global variables ****/ /**** Global variables ****/
extern WPreferences wPreferences; extern WPreferences wPreferences;
typedef struct _AppSettingsPanel {
WMWindow *win;
WAppIcon *editedIcon;
WWindow *wwin;
WMLabel *iconLabel;
WMLabel *nameLabel;
WMFrame *commandFrame;
WMTextField *commandField;
WMFrame *dndCommandFrame;
WMTextField *dndCommandField;
WMLabel *dndCommandLabel;
WMFrame *pasteCommandFrame;
WMTextField *pasteCommandField;
WMLabel *pasteCommandLabel;
WMFrame *iconFrame;
WMTextField *iconField;
WMButton *browseBtn;
WMButton *autoLaunchBtn;
WMButton *lockBtn;
WMButton *okBtn;
WMButton *cancelBtn;
Window parent;
/* kluge */
unsigned int destroyed:1;
unsigned int choosingIcon:1;
} AppSettingsPanel;
void DestroyDockAppSettingsPanel(AppSettingsPanel * panel);
static void updateCommand(WAppIcon * icon, char *command) static void updateCommand(WAppIcon * icon, char *command)
{ {
if (icon->command) if (icon->command)

66
src/dockedapp.h Normal file
View File

@@ -0,0 +1,66 @@
/*
* Window Maker window manager
*
* Copyright (c) 1997-2003 Alfredo K. Kojima
* Copyright (c) 1998-2003 Dan Pascu
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#ifndef WMDOCKEDAPP_H_
#define WMDOCKEDAPP_H_
typedef struct _AppSettingsPanel {
WMWindow *win;
WAppIcon *editedIcon;
WWindow *wwin;
WMLabel *iconLabel;
WMLabel *nameLabel;
WMFrame *commandFrame;
WMTextField *commandField;
WMFrame *dndCommandFrame;
WMTextField *dndCommandField;
WMLabel *dndCommandLabel;
WMFrame *pasteCommandFrame;
WMTextField *pasteCommandField;
WMLabel *pasteCommandLabel;
WMFrame *iconFrame;
WMTextField *iconField;
WMButton *browseBtn;
WMButton *autoLaunchBtn;
WMButton *lockBtn;
WMButton *okBtn;
WMButton *cancelBtn;
Window parent;
/* kluge */
unsigned int destroyed:1;
unsigned int choosingIcon:1;
} AppSettingsPanel;
void DestroyDockAppSettingsPanel(AppSettingsPanel *panel);
void ShowDockAppSettingsPanel(WAppIcon *aicon);
#endif