gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-22 05:48:01 +01:00
Code Issues Projects Releases Wiki Activity

WMaker: fix memory leak in app icon changing (Coverity #50139)

Browse Source 
As pointed by Coverity, there are some cases where the name of the file
returned by wIconChooserDialog could be left unfreed.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-20 21:46:41 +02:00
committed by Carlos R. Mafra
parent 3a68e974b6
commit c2a357fe1b
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/appicon.c
View File

@@ -534,14 +534,17 @@ static void setIconCallback(WMenu *menu, WMenuEntry *entry)
result = wIconChooserDialog(scr, &file, icon->wm_instance, icon->wm_class); result = wIconChooserDialog(scr, &file, icon->wm_instance, icon->wm_class);
if (result && !icon->destroyed) { if (result) {
if (!icon->destroyed) {
if (!wIconChangeImageFile(icon->icon, file)) { if (!wIconChangeImageFile(icon->icon, file)) {
wMessageDialog(scr, _("Error"), wMessageDialog(scr, _("Error"),
_("Could not open specified icon file"), _("OK"), NULL, NULL); _("Could not open specified icon file"),
_("OK"), NULL, NULL);
} else { } else {
wDefaultChangeIcon(icon->wm_instance, icon->wm_class, file); wDefaultChangeIcon(icon->wm_instance, icon->wm_class, file);
wAppIconPaint(icon); wAppIconPaint(icon);
} }
}
if (file) if (file)
wfree(file); wfree(file);
} }