From c5744aaa8b047f0f3f58422a00ba3f03f0d2912b Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Sat, 31 May 2014 19:58:39 +0200 Subject: [PATCH] WPrefs: make fall-back value look like a fall-back value in Texture Panel (Coverity #50031) As pointed by Coverity, the return value of 'sscanf' is not checked, which may not be a problem because the fall-back value for 'i' is provided before. However, if sscanf fails there is no guarantee that all implementation would leave 'i' untouched in case of parsing error, and for convenience it is more logical to write the code is such a way that the value assignment looks like the fall-back value it is. Signed-off-by: Christophe CURIS --- WPrefs.app/TexturePanel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WPrefs.app/TexturePanel.c b/WPrefs.app/TexturePanel.c index 9f2b86a5..58e9eccc 100644 --- a/WPrefs.app/TexturePanel.c +++ b/WPrefs.app/TexturePanel.c @@ -824,8 +824,8 @@ void SetTexturePanelTexture(TexturePanel * panel, const char *name, WMPropList * wfree(panel->imageFile); panel->imageFile = wstrdup(WMGetFromPLString(WMGetFromPLArray(texture, 1))); - i = 180; - sscanf(WMGetFromPLString(WMGetFromPLArray(texture, 2)), "%i", &i); + if (sscanf(WMGetFromPLString(WMGetFromPLArray(texture, 2)), "%i", &i) != 1) + i = 180; WMSetSliderValue(panel->topaS, i); p = WMGetFromPLArray(texture, 3);