gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-20 12:58:08 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: do not crash on NULL title in WMSetWindowTitle (Coverity #50046)

Browse Source 
As pointed by Coverity, despite apparent checks the function would fail if
trying to set a NULL title. Instead of trying to do over-complicated things
we just ignore (with a warning if NDEBUG is not set) the case. If user
wants an empty title, the correct way is to provide "" as we're not able to
remove a title.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-18 21:31:40 +02:00
committed by Carlos R. Mafra
parent 24e223dc27
commit c86de122f9
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
WINGs/wwindow.c
View File

@@ -255,12 +255,12 @@ static void setMiniwindow(WMWindow *win, RImage *image)
void WMSetWindowTitle(WMWindow * win, const char *title) void WMSetWindowTitle(WMWindow * win, const char *title)
{ {
wassertr(title != NULL);
if (win->title != NULL) if (win->title != NULL)
wfree(win->title); wfree(win->title);
if (title != NULL)
win->title = wstrdup(title); win->title = wstrdup(title);
else
win->title = NULL;
if (win->view->flags.realized) { if (win->view->flags.realized) {
setWindowTitle(win, title); setWindowTitle(win, title);