gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-28 01:12:30 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: removed unnecessary gotos in handleTextKeyPress

Browse Source 
When the condition can be simply checked in an if, it is better to do that
than to use a flow breaking goto.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-18 21:31:53 +02:00
committed by Carlos R. Mafra
parent 3a191af838
commit ca9dd144ae
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
WINGs/wtext.c
View File

@@ -2231,11 +2231,8 @@ static void handleTextKeyPress(Text * tPtr, XEvent * event)
case XK_Left: case XK_Left:
if (!(tb = tPtr->currentTextBlock)) if (!(tb = tPtr->currentTextBlock))
break; break;
if (tb->graphic)
goto L_imaGFX;
if (tPtr->tpos == 0) { if (tb->graphic || tPtr->tpos == 0) {
L_imaGFX:
if (tb->prior) { if (tb->prior) {
tPtr->currentTextBlock = tb->prior; tPtr->currentTextBlock = tb->prior;
if (tPtr->currentTextBlock->graphic) if (tPtr->currentTextBlock->graphic)
@@ -2256,10 +2253,7 @@ static void handleTextKeyPress(Text * tPtr, XEvent * event)
case XK_Right: case XK_Right:
if (!(tb = tPtr->currentTextBlock)) if (!(tb = tPtr->currentTextBlock))
break; break;
if (tb->graphic) if (tb->graphic || tPtr->tpos == tb->used) {
goto R_imaGFX;
if (tPtr->tpos == tb->used) {
R_imaGFX:
if (tb->next) { if (tb->next) {
tPtr->currentTextBlock = tb->next; tPtr->currentTextBlock = tb->next;
tPtr->tpos = 0; tPtr->tpos = 0;