From cf178d011b2cf0e64f6e231406efe3aacc5df5a4 Mon Sep 17 00:00:00 2001 From: David Maciejak Date: Wed, 1 Mar 2023 22:29:44 +0800 Subject: [PATCH] Coverity: fix WPrefs preference negative array index read --- WPrefs.app/Preferences.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/WPrefs.app/Preferences.c b/WPrefs.app/Preferences.c index 57f94461..6a9f8276 100644 --- a/WPrefs.app/Preferences.c +++ b/WPrefs.app/Preferences.c @@ -196,9 +196,13 @@ static void storeData(_Panel * panel) int i; i = WMGetPopUpButtonSelectedItem(panel->sizeP); + if (i < 0) + return; SetStringForKey(resize_display[i].db_value, "ResizeDisplay"); i = WMGetPopUpButtonSelectedItem(panel->posiP); + if (i < 0) + return; SetStringForKey(move_display[i].db_value, "MoveDisplay"); lr = WMGetButtonSelected(panel->lrB);