gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-23 14:42:29 +01:00
Code Issues Projects Releases Wiki Activity

wmaker: remove unnecessary check in acceptXDND (Coverity #72817)

Browse Source 
As pointed by Coverity, if dock is still null at this point then the
function will return via the previous check, because it is not possible to
have icon_pos >= 0 if dock is null.

This patch removes the check because it complicate the code which is not
recommended for maintainability.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-11-29 16:35:27 +01:00
committed by Carlos R. Mafra
parent 3dea732ccb
commit d83b5de644
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/xdnd.c
View File

@@ -226,8 +226,7 @@ static Bool acceptXDND(Window window)
} }
if (icon_pos < 0) if (icon_pos < 0)
return False; return False;
if (!dock)
return False;
if (isAwareXDND(dock->icon_array[icon_pos]->icon->icon_win)) if (isAwareXDND(dock->icon_array[icon_pos]->icon->icon_win))
return False; return False;