gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-02-12 03:35:52 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: Changed the minimum internal knob size of WScroller

Browse Source 
The original code allowed to have 0.0, but this can generate
division by zero in WScrollView. As a value of 0.0 is not realistic
anyway, use a minimum constant instead.
This commit is contained in:
Christophe CURIS
2013-05-11 00:07:17 +02:00
committed by Carlos R. Mafra
parent 8ef38e9910
commit dcfd7a4b5e
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
WINGs/wscroller.c
View File

@@ -154,6 +154,15 @@ void WMSetScrollerAction(WMScroller * sPtr, WMAction * action, void *clientData)
void WMSetScrollerParameters(WMScroller * sPtr, float floatValue, float knobProportion) void WMSetScrollerParameters(WMScroller * sPtr, float floatValue, float knobProportion)
{ {
/*
* This value represents 1 pixel on a 4k wide screen, it makes
* a good minimum; this ensure a non-null value to avoid
* potential division-by-0.
* Please note that there is another size check when drawing
* the knob to make sure it will remain selectable.
*/
static const float min_knob_proportion = 1.0 / 4096.0;
CHECK_CLASS(sPtr, WC_Scroller); CHECK_CLASS(sPtr, WC_Scroller);
assert(!isnan(floatValue)); assert(!isnan(floatValue));
@@ -165,9 +174,9 @@ void WMSetScrollerParameters(WMScroller * sPtr, float floatValue, float knobProp
else else
sPtr->floatValue = floatValue; sPtr->floatValue = floatValue;
if (knobProportion <= 0.0) { if (knobProportion <= min_knob_proportion) {
sPtr->knobProportion = 0.0; sPtr->knobProportion = min_knob_proportion;
sPtr->flags.documentFullyVisible = 0; sPtr->flags.documentFullyVisible = 0;
} else if (knobProportion >= 1.0) { } else if (knobProportion >= 1.0) {