1
0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-18 20:10:29 +01:00
Commit Graph

2 Commits

Author SHA1 Message Date
Christophe CURIS
af1bcde13a checkpatch: fix bug in regular expression
Recent version of perl seem to report incorrect stuff in regular expression
and this seems to be fixed in the kernel reference file, so this patch
brings the fix to our (older) version so we won't get that spurious message
when running the script.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
2014-12-10 10:19:18 +00:00
Carlos R. Mafra
337a6e9228 Add checkpatch.pl, stolen from the linux kernel
The coding style in wmaker.git follows the conventions of the linux kernel.

Therefore, I'm stealing their 'checkpatch' tool in an attempt to maximize
"perfect" patches to wmaker-dev, at least coding-style wise :-)

Before submitting your patch, please ('please' here means you must) check
it with:

./checkpatch your-patch.diff

and use your common sense to address any violations (error and/or warnings) detected.

There will always be false positives and other complaints that sometimes are better
dealt with by leaving them alone. No tool is perfect, but it _will_ detect obvious
errors which you must fix (warnings can be sometimes ignored).

I modified the script by removing kernel-specific stuff, but I don't guarantee
that I removed everything. I also increased the line length warning to 115.

In any case, it seems to work here and hopefully it will lead to a cleaner
and more consistent code base for wmaker.

PS: You can also check existing files, e.g.,

./checkpatch.pl --file src/icon.c
2014-05-19 17:28:52 +01:00