gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-01-20 00:54:13 +01:00
Code Issues Projects Releases Wiki Activity

Fill the :bmark command line generated by <a> with any existing data.

Browse Source 
Fixes #237 (The "a" key should fill command line with existing data on
bookmarked).
This commit is contained in:
Doug Kearns
2009-08-09 01:54:30 +10:00
parent 415db95601
commit 58c9041beb
1 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
common/content/bookmarks.js
View File

@@ -277,9 +277,26 @@ function Bookmarks() //{{{
function ()
{
let title = "";
if (buffer.title != buffer.URL)
title = " -title=\"" + buffer.title + "\"";
commandline.open(":", "bmark " + buffer.URL + title, modes.EX);
let keyword = "";
let tags = "";
let bmark = bookmarks.get(buffer.URL)[0];
if (bmark)
{
title = " -title=\"" + bmark.title + "\"";
if (bmark.keyword)
keyword = " -keyword=\"" + bmark.keyword + "\"";
if (bmark.tags.length > 0)
tags = " -tags=\"" + bmark.tags.join(", ") + "\"";
}
else
{
if (buffer.title != buffer.URL)
title = " -title=\"" + buffer.title + "\"";
}
commandline.open(":", "bmark " + buffer.URL + title + keyword + tags, modes.EX);
});
mappings.add(myModes, ["A"],
@@ -524,6 +541,7 @@ function Bookmarks() //{{{
},
// if starOnly = true it is saved in the unfiledBookmarksFolder, otherwise in the bookmarksMenuFolder
// FIXME: tags are not updated differentially
add: function add(starOnly, title, url, keyword, tags, force)
{
try
@@ -552,7 +570,11 @@ function Bookmarks() //{{{
if (keyword)
bookmarksService.setKeywordForBookmark(id, keyword);
if (tags)
{
// TODO: presumably this needs to be done in two Places transactions *double yawn* --djk
//taggingService.untagURI(uri, null);
taggingService.tagURI(uri, tags);
}
}
catch (e)
{