mirror of
https://github.com/gryf/pentadactyl-pm.git
synced 2026-03-10 05:55:47 +01:00
address Kris's double barrelled blasphemy
This commit is contained in:
@@ -604,6 +604,10 @@ function Bookmarks() //{{{
|
|||||||
{
|
{
|
||||||
// FIXME: returning here doesn't make sense
|
// FIXME: returning here doesn't make sense
|
||||||
// Why the hell doesn't it make sense? --Kris
|
// Why the hell doesn't it make sense? --Kris
|
||||||
|
// Because it unconditionally bypasses the final error message
|
||||||
|
// block and does so only when listing items, not opening them. In
|
||||||
|
// short it breaks the :bmarks command which doesn't make much
|
||||||
|
// sense to me but I'm old-fashioned. --djk
|
||||||
if (!openItems)
|
if (!openItems)
|
||||||
return completion.listCompleter("bookmark", filter, maxItems, tags);
|
return completion.listCompleter("bookmark", filter, maxItems, tags);
|
||||||
let items = completion.runCompleter("bookmark", filter, maxItems, tags);
|
let items = completion.runCompleter("bookmark", filter, maxItems, tags);
|
||||||
@@ -852,6 +856,7 @@ function History() //{{{
|
|||||||
{
|
{
|
||||||
// FIXME: returning here doesn't make sense
|
// FIXME: returning here doesn't make sense
|
||||||
// Why the hell doesn't it make sense? --Kris
|
// Why the hell doesn't it make sense? --Kris
|
||||||
|
// See comment at bookmarks.list --djk
|
||||||
if (!openItems)
|
if (!openItems)
|
||||||
return completion.listCompleter("history", filter, maxItems);
|
return completion.listCompleter("history", filter, maxItems);
|
||||||
let items = completion.runCompleter("history", filter, maxItems);
|
let items = completion.runCompleter("history", filter, maxItems);
|
||||||
|
|||||||
Reference in New Issue
Block a user