gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-23 16:22:27 +01:00
Code Issues Projects Releases Wiki Activity

add comment about recent literalArg handling change in commands#parseArgs

Browse Source
This commit is contained in:
Doug Kearns
2008-11-25 14:23:16 +00:00
parent c6fd8939f1
commit ab057c17a6
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
content/commands.js
View File

@@ -422,6 +422,16 @@ function Commands() //{{{
options = []; options = [];
if (literal) if (literal)
/*
TODO: This change doesn't seem right to me. It no longer
supports "?" which is really the only non-integer argCount
that makes much sense with a literal arg. Likewise, it no
longer supports "*" which we can allow and treat as "?" - "+"
as "1". I also don't like having argCounts > 1 specified as
integers and those below as strings, even if the former are
currently only used with 'literal'. I might be missing
something? -- djk
*/
var literalIndex = argCount == "+" ? 0 : Math.max(argCount - 1, 0); var literalIndex = argCount == "+" ? 0 : Math.max(argCount - 1, 0);
if (!argCount) if (!argCount)