gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-02-09 12:15:45 +01:00
Code Issues Projects Releases Wiki Activity

Just explicitly check bookmark node URIs for nullness. How does this even happen?

Browse Source
This commit is contained in:
Kris Maglione
2009-11-08 20:58:43 -05:00
parent 6a25312c7d
commit b117f6749a
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
common/content/bookmarks.js
View File

@@ -60,20 +60,15 @@ const Bookmarks = Module("bookmarks", {
this.__iterator__ = function () (val for ([, val] in Iterator(self.bookmarks)));
function loadBookmark(node) {
try {
let uri = util.newURI(node.uri);
let keyword = bookmarksService.getKeywordForBookmark(node.itemId);
let tags = tagging.getTagsForURI(uri, {}) || [];
let bmark = new Bookmark(node.uri, node.title, node.icon && node.icon.spec, keyword, tags, node.itemId);
if (node.uri == null) // How does this happen?
return false;
let uri = util.newURI(node.uri);
let keyword = bookmarksService.getKeywordForBookmark(node.itemId);
let tags = tagging.getTagsForURI(uri, {}) || [];
let bmark = new Bookmark(node.uri, node.title, node.icon && node.icon.spec, keyword, tags, node.itemId);
bookmarks.push(bmark);
return bmark;
}
catch (e) {
liberator.dump("Failed to create bookmark for URI: " + node.uri);
liberator.reportError(e);
return null;
}
bookmarks.push(bmark);
return bmark;
}
function readBookmark(id) {