gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 09:48:00 +01:00
Code Issues Projects Releases Wiki Activity

Revert 93b0cf2a063b045268a55fbeac9473ce12234300's changes to hints.js

Browse Source 
Until liberator.NEW_BACKGROUND_TAB operates differently based on the
    setting of browser.tabs.loadInBackground, this code must remain. At
    the moment, NEW_BACKGROUND_TAB only opens a true background tab if
    loadInBackground=true. When loadInBackground=false, the meaning of
    NEW_TAB and NEW_BACKGROUND_TAB flip. Hence, until they're invariant,
    something like ;F (which must always load tabs in the background)
    has to pay attention to loadInBackground.
This commit is contained in:
Ted Pavlic
2009-01-08 08:51:34 -05:00
parent e581465101
commit d90e670d70
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/content/hints.js
View File

@@ -86,7 +86,13 @@ function Hints() //{{{
// Used to open multiple hints // Used to open multiple hints
function hintSequenceElement(elem) function hintSequenceElement(elem)
{ {
buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB); // Want to always open sequence hints in background
// (remember: NEW_BACKGROUND_TAB and NEW_TAB semantics assume
// that loadInBackground=true)
if (options.getPref("browser.tabs.loadInBackground"))
buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB);
else
buffer.followLink(elem, liberator.NEW_TAB);
// Move to next element in sequence // Move to next element in sequence
// TODO: Maybe we find a *simple* way to keep the hints displayed rather than // TODO: Maybe we find a *simple* way to keep the hints displayed rather than