gryf/wicd
1
0
Fork 0
mirror of https://github.com/gryf/wicd.git synced 2025-12-26 00:12:29 +01:00
Code Issues Projects Releases Wiki Activity

Automatic reconnect: honour the automatic reconnect configuration, even if the GUI interface is open

Browse Source 
When a user actives "automatic reconnnect" and then tries this out, he will be staring at the GUI interface, waiting for a reconnect.
But wicd-daemon refuses to reconnect when the GUI interface is open, and fails to reports this to the GUI user.
Hence users assume that this feature does not work properly (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567).

This commit fixes that by doing a reconnect, no matter whether the GUI is open or not, thus taking the path of "least surprise".
The original rationale for not reconnecting when the GUI is open was never stated in the comments, nor in the commit message.
This commit is contained in:
Tom Van Braeckel
2014-11-05 07:32:28 +01:00
parent cc4573bf7c
commit d32482afb9
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
wicd/wicd-daemon.py
View File

@@ -367,11 +367,6 @@ class WicdDaemon(dbus.service.Object, object):
if self.debug_mode:
print 'Already connecting, doing nothing.'
return
# We don't want to rescan/connect if the gui is open.
if self.gui_open:
if self.debug_mode:
print "Skipping autoconnect because GUI is open."
return
if self.wired_bus.CheckPluggedIn():
if self.debug_mode:
print "Starting wired autoconnect..."