gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-20 21:08:08 +01:00
Code Issues Projects Releases Wiki Activity

wmaker: removed unnecessary check when painting application icon (Coverity #50052)

Browse Source 
As pointed by Coverity, there was a check for null pointer on
scr->dock_dots, but this check was not made in the 2nd use of it, done if
the HIDDENDOT feature was enabled.

Investigation show that it is not possible that this pointer could be
created NULL, so let's remove the unneeded check.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
Signed-off-by: Carlos R. Mafra <crmafra@gmail.com>
This commit is contained in:
Christophe CURIS
2014-11-15 19:40:38 +01:00
committed by Carlos R. Mafra
parent 810796b390
commit 3d9c059591
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/appicon.c
View File

@@ -411,7 +411,7 @@ void wAppIconPaint(WAppIcon *aicon)
if (aicon->docked && scr->dock && scr->dock == aicon->dock && aicon->yindex == 0) if (aicon->docked && scr->dock && scr->dock == aicon->dock && aicon->yindex == 0)
updateDockNumbers(scr); updateDockNumbers(scr);
# endif # endif
if (scr->dock_dots && aicon->docked && !aicon->running && aicon->command != NULL) { if (aicon->docked && !aicon->running && aicon->command != NULL) {
XSetClipMask(dpy, scr->copy_gc, scr->dock_dots->mask); XSetClipMask(dpy, scr->copy_gc, scr->dock_dots->mask);
XSetClipOrigin(dpy, scr->copy_gc, 0, 0); XSetClipOrigin(dpy, scr->copy_gc, 0, 0);
XCopyArea(dpy, scr->dock_dots->image, aicon->icon->core->window, XCopyArea(dpy, scr->dock_dots->image, aicon->icon->core->window,