gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-22 14:08:06 +01:00
Code Issues Projects Releases Wiki Activity

WMaker: remove unnecessary check in Balloon show function (Coverity #50065)

Browse Source 
As pointed by Coverity, there is a check to make sure a pointer is not NULL
but it is still dereferenced later in the function. As the code is done so
that this pointer cannot be NULL then it is not necessary to check that.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-20 21:46:29 +02:00
committed by Carlos R. Mafra
parent ca64091f05
commit 7f840db1aa
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/balloon.c
View File

@@ -382,10 +382,8 @@ static void showBalloon(WScreen * scr)
Window foow; Window foow;
unsigned foo, w; unsigned foo, w;
if (scr->balloon) {
scr->balloon->timer = NULL; scr->balloon->timer = NULL;
scr->balloon->ignoreTimer = 1; scr->balloon->ignoreTimer = 1;
}
if (!XGetGeometry(dpy, scr->balloon->objectWindow, &foow, &x, &y, &w, &foo, &foo, &foo)) { if (!XGetGeometry(dpy, scr->balloon->objectWindow, &foow, &x, &y, &w, &foo, &foo, &foo)) {
scr->balloon->prevType = 0; scr->balloon->prevType = 0;