gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-30 02:12:30 +01:00
Code Issues Projects Releases Wiki Activity

WPrefs: fix memory leak when storing the list of texture in Appearence panel (Coverity #50112)

Browse Source 
As pointed by Coverity, the PLStrings created to store the information on
the texture leak. This is due to the fact that they are created with a
refCount of 1, then the PLArray in which they are placed increments that
count, so at list destruction the count would return to 1 instead of 0,
meaning the PLStrings won't be freed.

This patch release the PLStrings once after adding them to the PLArray so
the count will go back to 1, which means they will be properly freed when
the PLArray will be released.

Took opportunity to remove the call to WMRetainPropList on the titem-prop
because it artificially increases the refCount but this is already done
when adding to the PLArray.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-12-07 17:10:21 +01:00
committed by Carlos R. Mafra
parent af1bcde13a
commit be4849448f
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
WPrefs.app/Appearance.c
View File

@@ -2207,11 +2207,16 @@ static void prepareForClose(_Panel * panel)
/* store list of textures */
for (i = 8; i < WMGetListNumberOfRows(panel->texLs); i++) {
WMPropList *pl_title, *pl_path;
item = WMGetListItem(panel->texLs, i);
titem = (TextureListItem *) item->clientData;
texture = WMCreatePLArray(WMCreatePLString(titem->title),
WMRetainPropList(titem->prop), WMCreatePLString(titem->path), NULL);
pl_title = WMCreatePLString(titem->title);
pl_path = WMCreatePLString(titem->path);
texture = WMCreatePLArray(pl_title, titem->prop, pl_path, NULL);
WMReleasePropList(pl_title);
WMReleasePropList(pl_path);
WMAddToPLArray(textureList, texture);
}