1
0
mirror of https://github.com/gryf/wmaker.git synced 2026-01-03 12:24:17 +01:00

- WMGetTextDefaultColor() won't retain the returned color anymore, and you

shouldn't release it. It is just a reference to the internal WMText color.
  This should make all the functions returning colors from widgets behave
  consistently
This commit is contained in:
dan
2002-11-30 03:00:34 +00:00
parent bde9b8a21a
commit c0442b1c59
4 changed files with 4 additions and 3 deletions

View File

@@ -47,6 +47,8 @@ Changes since wmaker 0.80.1:
- Fixed a memory leak in wfontpanel.c
- Added a check that only %d is used in a font specification in WMGLOBAL and at
most once for each font in a fontset (eliminates a possible security exploit)
- Fixed WMGetTextDefaultColor() not to retain the returned color. It returns
only a reference to the internal color, which you shouldn't release
Changes since wmaker 0.80.0:

View File

@@ -1401,7 +1401,7 @@ WMGetColorPanelColor(WMColorPanel *panel)
return WMGetColorWellColor(panel->colorWell);
}
void
WMSetColorPanelColor(WMColorPanel *panel, WMColor *color)
{

View File

@@ -1070,7 +1070,6 @@ WMSetWidgetBackgroundColor(WMWidget *w, WMColor *color)
WMColor*
WMGetWidgetBackgroundColor(WMWidget *w)
{
// should retain?
return W_VIEW(w)->backColor;
}

View File

@@ -3948,7 +3948,7 @@ WMSetTextDefaultColor(WMText *tPtr, WMColor *color)
WMColor*
WMGetTextDefaultColor(WMText *tPtr)
{
return WMRetainColor(tPtr->dColor);
return tPtr->dColor;
}