gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-01-10 15:54:17 +01:00
Code Issues Projects Releases Wiki Activity

WPrefs: fix memory leak in loadRImage (Coverity #50107)

Browse Source 
As pointed by Coverity, if there is a problem when reading the binary data
of an RImage from a file, the area allocated to store it would not be
freed.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-31 19:58:43 +02:00
committed by Carlos R. Mafra
parent a9e2923f67
commit c54bb11ee9
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
WPrefs.app/Appearance.c
View File

@@ -1276,13 +1276,13 @@ static Pixmap loadRImage(WMScreen * scr, const char *path)
}
image = RCreateImage(w, h, d == 4);
read_size = w * h * d;
if (fread(image->data, 1, read_size, f) != read_size) {
fclose(f);
return None;
}
if (fread(image->data, 1, read_size, f) == read_size)
RConvertImage(WMScreenRContext(scr), image, &pixmap);
else
pixmap = None;
fclose(f);
RConvertImage(WMScreenRContext(scr), image, &pixmap);
RReleaseImage(image);
return pixmap;