gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2026-01-10 07:44:14 +01:00
Code Issues Projects Releases Wiki Activity

WINGs: Minor improvments in 'closestListItem' function

Browse Source 
The check on length of string before comparing is not necessary
because this will be checked as part of strcmp; the check won't
save time and may actually cost.

As the number of element in the array is not going to change during
the loop, took the call to 'WMGetArrayItemCount' outside the loop
to be faster (and ease compiler's optimisation work).

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2013-11-10 17:41:05 +01:00
committed by Carlos R. Mafra
parent 10953b3a7e
commit d25631016e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
WINGs/wfilepanel.c
View File

@@ -93,16 +93,16 @@ static int closestListItem(WMList * list, const char *text, Bool exact)
{
WMListItem *item;
WMArray *items = WMGetListItems(list);
int i, len = strlen(text);
int i, nb_item, len = strlen(text);
if (len == 0)
return -1;
for (i = 0; i < WMGetArrayItemCount(items); i++) {
nb_item = WMGetArrayItemCount(items);
for (i = 0; i < nb_item; i++) {
item = WMGetFromArray(items, i);
if (strlen(item->text) >= len &&
((exact && strcmp(item->text, text) == 0) ||
(!exact && strncmp(item->text, text, len) == 0))) {
if ((exact && strcmp(item->text, text) == 0) ||
(!exact && strncmp(item->text, text, len) == 0)) {
return i;
}
}