Christophe CURIS e828e1c074 Fix use-after-free error in wIconStore reported by Coverity ...

The function always returns the filename where the icon have been saved,
but in the case where the save operation failed we would free the memory
for that file name, yet still return this pointer like if it were valid.

Took opportunity to remove redundant free(path) which is done a couple
lines later, because redundancy is a source of problem for code
maintenance.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>

2021-05-18 17:49:17 +01:00

..

actions.c

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

actions.h

Added missing function declaration.

2019-08-06 11:04:05 +01:00

appicon.c

Remove trailing whitespace.

2020-04-09 14:28:09 +01:00

appicon.h

Remove unused argument in save_appicon

2015-08-23 22:08:30 +01:00

application.c

Enable usermenu

2015-08-25 15:42:06 +01:00

application.h

Icon functions moved to appicon.c

2012-06-18 22:25:57 +01:00

appmenu.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

appmenu.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

balloon.c

wmaker: Fix typos (used codespell).

2016-01-17 22:54:49 -05:00

balloon.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

client.c

wmaker: fix misuse of 'user_flags' instead of 'client_flags' for window attributes

2015-05-15 17:44:50 +01:00

client.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

colormap.c

wmaker: Cleaned dangerous function prototype usage

2013-05-12 01:01:20 +01:00

colormap.h

New colormap header file and remove unused functions

2012-06-25 23:49:10 +01:00

cycling.c

wmaker: allow alt+tabbed windows over fullscreen

2016-07-12 23:21:00 +01:00

cycling.h

New header file cycling.h

2013-05-26 19:48:00 +01:00

def_pixmaps.h

New titlebar button style

2010-09-11 17:32:57 +02:00

defaults.c

Added Expert option: "Close rootmenu when mouse (left or right) is clicked outside focus.

2020-09-13 16:56:09 +01:00

defaults.h

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

dialog.c

bump copyright year in Info Panel

2020-03-25 10:08:17 +00:00

dialog.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

dock.c

Remove trailing whitespace.

2020-04-09 14:28:09 +01:00

dock.h

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

dockedapp.c

Renamed the ScaleX/Y macros and their local variables

2019-06-19 18:06:53 +01:00

dockedapp.h

Address unprototyped call in dock.c

2012-06-23 12:09:41 +01:00

event.c

Added Expert option: "Close rootmenu when mouse (left or right) is clicked outside focus.

2020-09-13 16:56:09 +01:00

event.h

wmaker: Moved function prototype to the appropriate header

2013-06-30 15:10:09 +01:00

extend_pixmaps.h

New titlebar button style

2010-09-11 17:32:57 +02:00

framewin.c

wmaker: removed unused macro DBLCLICK_TIME

2014-12-10 10:19:19 +00:00

framewin.h

Allow setting separate border color for focused windows

2014-05-19 21:37:26 +01:00

geomview.c

Fixed structure declaration syntax

2013-06-10 22:34:59 +01:00

geomview.h

Added missing include guards in a few headers

2013-05-10 19:37:47 +01:00

GNUstep.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

icon.c

Fix use-after-free error in wIconStore reported by Coverity

2021-05-18 17:49:17 +01:00

icon.h

Remove cache icon when detached

2015-08-23 22:08:30 +01:00

keybind.h

support moving window between heads using keyboard

2018-12-16 10:13:50 +00:00

main.c

configure: Add option to specify global defaults directory.

2017-03-10 10:20:58 +00:00

main.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

Makefile.am

WINGs: Fix incorrect use of macro USE_PANGO in installed header

2021-05-18 17:49:17 +01:00

menu.c

Fix various abs() issues.

2020-04-18 19:49:26 +01:00

menu.h

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

misc.c

configure: Add option to specify global defaults directory.

2017-03-10 10:20:58 +00:00

misc.h

wmaker: remove one level of pointers for the function SlideWindows

2015-05-08 18:53:30 +01:00

monitor.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

monitor.h

New header file monitor.h

2013-05-26 19:48:00 +01:00

motif.c

Fixed expression checking whether flag is set.

2019-08-06 11:04:05 +01:00

motif.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

moveres.c

Fix various abs() issues.

2020-04-18 19:49:26 +01:00

osdep_bsd.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

osdep_darwin.c

Patch for GetCommandForPid() in osdep_darwin.c

2020-10-19 20:38:29 +01:00

osdep_linux.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

osdep_stub.c

wmaker: replaced old email address with the official one

2015-06-13 08:40:50 -06:00

osdep.h

funcs.h removed

2013-05-26 19:48:00 +01:00

pixmap.c

Removed unused WScreen argument in Pixmap function

2013-10-12 15:18:06 +01:00

pixmap.h

Removed unused WScreen argument in Pixmap function

2013-10-12 15:18:06 +01:00

placement.c

Added explicit fall-through comments to pacify GCC.

2019-08-06 11:04:05 +01:00

placement.h

wmaker: Remove prototype for unused get_right_position_on_screen function.

2016-01-17 22:54:49 -05:00

properties.c

wmaker: Moved definition of WMaker-specific XAtoms into the global variables structure

2013-09-30 00:53:10 +02:00

properties.h

Remove unused functions

2012-04-04 19:44:40 +01:00

resources.c

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

resources.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

rootmenu.c

Fix memory leak reported by Coverity

2021-05-18 17:49:17 +01:00

rootmenu.h

Added Expert option: "Close rootmenu when mouse (left or right) is clicked outside focus.

2020-09-13 16:56:09 +01:00

screen.c

Make dock dots scalable

2021-05-07 18:03:19 +01:00

screen.h

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

session.c

wmaker: Fix typos (used codespell).

2016-01-17 22:54:49 -05:00

session.h

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

shutdown.c

wmaker: Moved variables for Inotify into the global namespace

2013-10-11 21:58:13 +01:00

shutdown.h

Added missing include guards in a few headers

2013-05-10 19:37:47 +01:00

stacking.c

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

stacking.h

stacking.h removed white lines

2012-11-19 00:12:46 +01:00

startup.c

wmaker: Fix typos (used codespell).

2016-01-17 22:54:49 -05:00

startup.h

New header file startup.h

2013-05-26 19:48:00 +01:00

superfluous.c

wmaker: superfluous.c possible null pointer dereference

2014-07-27 09:45:03 -06:00

superfluous.h

Real-time dock left-right swapping

2013-04-12 02:14:10 +01:00

switchmenu.c

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

switchmenu.h

New header file switchmenu.h

2013-05-26 19:48:00 +01:00

switchpanel.c

Fix usage of float constant reported by gcc

2021-05-18 17:49:17 +01:00

switchpanel.h

Support for same-class cycling in open switchpanel.

2013-05-02 20:41:07 +01:00

texture.c

wmaker: removed case from switch that is unreachable (Coverity #50043)

2014-11-23 22:43:38 +00:00

texture.h

wmaker: Added 'const' attribute to remaining functions

2013-06-16 19:32:23 +01:00

usermenu.c

wmaker: Fix typos (used codespell).

2016-01-17 22:54:49 -05:00

usermenu.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

wconfig.h.in

Remove trailing whitespace.

2020-04-09 14:28:09 +01:00

wcore.c

wmaker: Moved definition of X Contexts into the global variables structure

2013-09-30 00:53:10 +02:00

wcore.h

Window attributes moved to wCoreCreateTopLevel

2013-03-21 10:01:04 +00:00

wdefaults.c

wmaker: Add new advanced option to ignore decoration changes from clients.

2018-02-14 08:16:55 +00:00

wdefaults.h

switchpanel: Add skip_switchpanel advanced option

2011-02-17 19:29:15 +01:00

window.c

Double click on titlebar maximize a window to fullscreen

2020-08-10 12:15:01 +01:00

window.h

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

WindowMaker.h

Added Expert option: "Close rootmenu when mouse (left or right) is clicked outside focus.

2020-09-13 16:56:09 +01:00

winmenu.c

Added 'head' parameter to wMaximizeWindow

2017-02-08 07:26:35 +00:00

winmenu.h

New header file winmenu.h

2013-05-26 19:48:00 +01:00

winspector.c

Remove apostrophes from instances of possessive "its".

2020-04-09 09:05:50 +01:00

winspector.h

Added explicit 'void' to function that takes no argument

2013-05-12 01:01:20 +01:00

wmspec.c

Correct calculation of usable space for reserved area.

2021-03-18 16:08:40 +00:00

wmspec.h

wmaker: implement EWMH _NET_WORKAREA

2014-08-29 12:43:50 +01:00

workspace.c

Fixed couple of compilator warning and removed unused macros.

2017-02-25 10:19:52 +00:00

workspace.h

wmaker: add core workspace pager functions

2014-12-10 10:19:18 +00:00

wsmap.c

wmaker: remove one level of pointers for the function SlideWindows

2015-05-08 18:53:30 +01:00

wsmap.h

wmaker: moved the variable 'process_workspacemap_event' to the global namespace

2014-12-10 10:19:18 +00:00

xdnd.c

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

xdnd.h

wmaker: Improve drag-nd-drop support

2014-08-15 01:08:23 +01:00

xinerama.c

Fix various abs() issues.

2020-04-18 19:49:26 +01:00

xinerama.h

Added wGetHeadRelativeToCurrentHead function

2017-02-08 07:26:35 +00:00

xmodifier.c

wmaker: add missing source files for translation

2015-01-20 21:29:24 +00:00

xmodifier.h

wmaker: improve key shortcut labelling

2014-11-02 12:50:02 +01:00

xutil.c

wmaker: Fix typos (used codespell).

2016-01-17 22:54:49 -05:00

xutil.h

Added proper legal notice at beginning of header files

2013-05-10 19:37:47 +01:00