gryf/wmaker
1
0
Fork 0
mirror of https://github.com/gryf/wmaker.git synced 2025-12-18 20:10:29 +01:00
Code Issues Projects Releases Wiki Activity

WPrefs: fix memory leak when editing the label of a menu (Coverity #50130)

Browse Source 
As pointed by Coverity, the function 'WMGetTextFieldText' already allocates
memory for its return string, so it is not necessary to wstrdup it.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
This commit is contained in:
Christophe CURIS
2014-05-31 19:58:44 +02:00
committed by Carlos R. Mafra
parent c54bb11ee9
commit 27a2259934
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
WPrefs.app/editmenu.c
View File

@@ -809,13 +809,9 @@ static void handleEvents(XEvent * event, void *data)
static void stopEditItem(WEditMenu * menu, Bool apply)
{
char *text;
if (apply) {
text = WMGetTextFieldText(menu->tfield);
wfree(menu->selectedItem->label);
menu->selectedItem->label = wstrdup(text);
menu->selectedItem->label = WMGetTextFieldText(menu->tfield);
updateMenuContents(menu);